Branch cut updates by fortmarek · Pull Request #3645 · react/react-native-website

fortmarek · 2023-03-24T13:38:46Z

Updating the release docs after 0.72 branch cut off and RC0 release with the new steps to update and align packages on the new monorepo setup
Moving the wiki page that explains the new utility commands for updating packages to the website. The wiki page should link to the website documentation once this PR is merged.

netlify · 2023-03-24T13:40:25Z

✅ Deploy Preview for react-native ready!

Name	Link
🔨 Latest commit	`9c1cfdc`
🔍 Latest deploy log	https://app.netlify.com/sites/react-native/deploys/646f0e41a8bda50008633eb4
😎 Deploy Preview	https://deploy-preview-3645--react-native.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

hoxyq · 2023-04-03T10:07:44Z

+The packages in the `react-native` monorepo should be always one minor version ahead of the latest or RC version. Once you're done with releasing the initial RC0, you should:
+
+- Create a new branch in `react-native` from `main` in your own fork.
+- Run `npm run bump-all-updated-packages --release-branch-cutoff` to bump the minor versions of all packages.


Suggested change

- Run `npm run bump-all-updated-packages --release-branch-cutoff` to bump the minor versions of all packages.

- Run `npm run bump-all-updated-packages -- --release-branch-cutoff` to bump the minor versions of all packages.

For npm we need to add explicit --, because node accepts arguments in a form like --<arg>

This is not true for yarn, though. So we can change in to yarn bump-all-updated-packages --release-branch-cutoff or provide both variants.

hoxyq · 2023-04-03T10:08:00Z

+
+#### How to execute
+
+`npm run bump-all-updated-packages` or `npm run bump-all-updated-packages --release-branch-cutoff`


Suggested change

`npm run bump-all-updated-packages` or `npm run bump-all-updated-packages --release-branch-cutoff`

`npm run bump-all-updated-packages` or `npm run bump-all-updated-packages -- --release-branch-cutoff`

I used yarn instead since that's the tool of choice for other commands such as running test-e2e-local

I used yarn instead since that's the tool of choice for other commands such as running test-e2e-local

Can you please update examples of executing this command with yarn? I don't have a strong opinion on if we should include both, seems pretty straightforward, but definitely better for it to be either yarn or npm everywhere

Fair point, done 👍

hoxyq · 2023-04-03T10:11:03Z


 - Add and commit the extra file that got created at `sdks/hermes/.hermesversion`.

+- Update packages in the monorepo by running `npm run bump-all-updated-packages`. All the package bumps should be a patch. Read more about the script and how they work [here](./release-updating-packages).


Can we add one more sentence on why we need to do it?

Maybe something like "We need to publish the latest available changes in our code, so they will be included in a new RC"

kelset

Good stuff, thanks for working on this @fortmarek! I've left a few suggestions improvements and one main change that I think will make the guide more streamlined.

kelset · 2023-04-06T11:05:27Z

+- Update packages in the monorepo by running `yarn bump-all-updated-packages`. All the package bumps should be a patch. We need to publish the latest package changes, so they will be included in a new RC. Read more about the script and how they work [here](./release-updating-packages).
+- Push the commit created by the previous command to the `0.x-stable` branch.
+
 ### 2. Push the branch and test the current changes


I just noticed that in this guide we only push the branch up at this step 2.

Maybe let's change this second step to be part of step 1, and separate the Hermes bump into its own step and the bump all packages into its own step too?

I created separate steps for Hermes and monorepo packages bumps.

I kept this step as a separate one that we should still run only after Hermes + packages bumps as I don't think it's necessary to push multiple times? Or do you see the workflow as:

Create new branch, push its current state

Hermes bump

monorepo bumps

push the changes again

I think it's ok

kelset · 2023-05-24T16:07:42Z

LGTM thanks @fortmarek - can you just fix the lint error?

Then @Simek this can be merged 👍

Simek · 2023-05-25T08:16:31Z

+This page contains relevant information about how to update packages in the `react-native` [monorepo](https://github.com/react-native-community/discussions-and-proposals/pull/480).
+


Not sure if linking RFC add anything useful for the page context.

Simek

Just one nit about RFC link, other than that LGTM! 👍

Let's cross-check with someone form Meta before landing this tho.

kelset · 2023-05-25T10:32:07Z

@Simek for the Meta approval, @hoxyq is from Meta and he wrote the original doc that we're importing, so we can already go ahead without needing Nicola ;)

facebook-github-bot added CLA Signed p: shopify Partner labels Mar 24, 2023

fortmarek force-pushed the fortmarek/branch-cut-updates branch from b9c4b29 to 6da53c0 Compare March 24, 2023 13:42

fortmarek force-pushed the fortmarek/branch-cut-updates branch 3 times, most recently from 601402f to 7bb8dd2 Compare April 3, 2023 09:45

fortmarek requested a review from hoxyq April 3, 2023 09:45

fortmarek marked this pull request as ready for review April 3, 2023 09:46

hoxyq reviewed Apr 3, 2023

View reviewed changes

hoxyq approved these changes Apr 3, 2023

View reviewed changes

fortmarek force-pushed the fortmarek/branch-cut-updates branch 3 times, most recently from d8f24c7 to fe8da5e Compare April 3, 2023 11:05

kelset reviewed Apr 6, 2023

View reviewed changes

Comment thread website/contributing/release-branch-cut-and-rc0.md Outdated

fortmarek force-pushed the fortmarek/branch-cut-updates branch 2 times, most recently from 19c5917 to bc4a88b Compare May 18, 2023 18:22

fortmarek requested a review from kelset May 18, 2023 18:22

Add step for updating packages in the release guide

9c1cfdc

fortmarek force-pushed the fortmarek/branch-cut-updates branch from bc4a88b to 9c1cfdc Compare May 25, 2023 07:29

Simek reviewed May 25, 2023

View reviewed changes

Simek approved these changes May 25, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

Simek requested review from cortinico and removed request for kelset May 25, 2023 08:20

Simek merged commit 5897bef into react:main May 25, 2023

	- Run `npm run bump-all-updated-packages --release-branch-cutoff` to bump the minor versions of all packages.
	- Run `npm run bump-all-updated-packages -- --release-branch-cutoff` to bump the minor versions of all packages.


		#### How to execute

		`npm run bump-all-updated-packages` or `npm run bump-all-updated-packages --release-branch-cutoff`


		- Add and commit the extra file that got created at `sdks/hermes/.hermesversion`.

		- Update packages in the monorepo by running `npm run bump-all-updated-packages`. All the package bumps should be a patch. Read more about the script and how they work [here](./release-updating-packages).

		This page contains relevant information about how to update packages in the `react-native` [monorepo](https://github.com/react-native-community/discussions-and-proposals/pull/480).

Conversation

fortmarek commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for react-native ready!

Uh oh!

hoxyq Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kelset left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kelset commented May 24, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Simek left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

Uh oh!

kelset commented May 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fortmarek commented Mar 24, 2023 •

edited

Loading

netlify Bot commented Mar 24, 2023 •

edited

Loading

hoxyq Apr 3, 2023 •

edited

Loading